Martin Skarsaune

Results 41 comments of Martin Skarsaune

Jolokia is updated now. Merged with master and marking ready for review. PR is ready for slaughter 😉 Kuternetes tests still fail when I run `./build.sh --test` I need some...

Found a functional problem with the Kubernetes test after upgrading to jolokia 1.7.2. will investigate ASAP Edit: fixed https://github.com/openjdk/jmc/pull/332/commits/b33f15be2161c2eeae21890e61359387a1bdbb33

@thegreystone : I believe the previous review should be addressed. You can have a new look when you have time, and any assistance on running the test would be appreciated.

Still troubleshooting Kubernetes tests. Now they run , but fail with class not found on Apache commons http classes

Sorry, missed this email. I'm still struggling with the classloading of the kubernetes tests, and it has been hard to prioritze lately. It should be reproducible running `./build.sh --test` on...

Wondering if it is easiest to simply rip the PR in 2. Then we could merge joloka and struggle on with Kubernetes 😅 On Tue, Jan 23, 2024 at 7:25 ...

replaced by https://github.com/openjdk/jmc/pull/548

Great, that is very helpful. Thanks for the quick feedback.

Update: Something does not seem to work after updating to master. I will debug a bit, but do not have the time the next couple of days

Ok, so at least in JMC 7.1.0 and 8.3.0 this use to work by the fact that the plugin uses the extension point for JMX protocol: https://github.com/skarsaune/jmc/blob/e2c2275d05ee2e2215ea2a48b720ef2fef456810/application/org.openjdk.jmc.jolokia/plugin.xml#L43 However this no...