nomnoml icon indicating copy to clipboard operation
nomnoml copied to clipboard

Fix/support for short color notation

Open bdlabs opened this issue 2 years ago • 11 comments

Fixed render svg. Add support for short color notation.

bdlabs avatar Feb 18 '23 13:02 bdlabs

Very interesting to let uers register their own styles! I will have to think a bit about this as this new public API will freeze the current implementation of layouters and visualizers.

skanaar avatar Feb 20 '23 07:02 skanaar

OK, can you explain how? Maybe I missed something :)

bdlabs avatar Feb 20 '23 17:02 bdlabs

@bdlabs the sames changes appear in both this PR and in #193 . I got a bit confused.

What I mean is that right now the layouter and visualizer systems are private parts of nomnoml. So I am free to change them around whenever without breaking the public API.

If they are exposed they are "locked into place" and any changes to those systems would mean a breaking change. So I would have to think carefully about that.

skanaar avatar Feb 20 '23 18:02 skanaar

Could you remove the stuff related to registerComponent from this PR so it only deals with the color notation? Thanks

skanaar avatar Feb 20 '23 18:02 skanaar

My mistake, I did the merge wrong, didn't notice it :), I'll fix it today. Thanks.

bdlabs avatar Feb 21 '23 07:02 bdlabs

Hi, what about this theme? :)

bdlabs avatar Mar 02 '23 11:03 bdlabs

Thank you for the reminder. I'm on a short vacation for the moment, will look at this next week.

skanaar avatar Mar 02 '23 11:03 skanaar

@bdlabs which SVG viewer are you using that gave you a buggy rendering? Because I cannot reproduce the bug that this is supposed to solve.

skanaar avatar Mar 06 '23 21:03 skanaar

@skanaar sorry, I don't remember. It was probably a render in phpstorm.

bdlabs avatar Mar 18 '23 12:03 bdlabs

Hmm, I will close this PR since I cannot reproduce the bug. But I really appreciate the effort.

skanaar avatar Mar 18 '23 13:03 skanaar

Reopening as I can reproduce it in JetBrains Fleet.

skanaar avatar Mar 19 '23 15:03 skanaar