aqi-wtf icon indicating copy to clipboard operation
aqi-wtf copied to clipboard

Implement AQI background color scale

Open wdibi opened this issue 3 years ago • 5 comments

wdibi avatar Sep 14 '20 07:09 wdibi

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/skalnik/aqi-wtf/pe62s24yf
✅ Preview: https://aqi-wtf-git-fork-wdibi-feature-aqi-color-scale.skalnik.vercel.app

vercel[bot] avatar Sep 14 '20 07:09 vercel[bot]

Hi @wdibi - Thanks so much for the contribution.

d3....feels like a pretty heavy hammer for this - It adds about 260k of download and adds a hard dependency on a third-party site, which is something we've tried hard to avoid up to now. I think I'd be happier pulling a single calculation function into app.js

obra avatar Sep 14 '20 17:09 obra

Hey @obra, I can implement a similar solution with chroma.js. Thoughts on its size? https://bundlephobia.com/[email protected]

wdibi avatar Sep 14 '20 19:09 wdibi

@wdibi It -looks- like https://stackoverflow.com/a/63775249 should do what we want. Wanna give it a shot with that?

obra avatar Sep 14 '20 22:09 obra

@obra Sure, I will take a look.

wdibi avatar Sep 14 '20 23:09 wdibi