Sebastian Kreft

Results 88 issues of Sebastian Kreft

Currently apply_fix is too slow. I reckon this is due to the fact that if a file has many violations, the linter will be run as many times. For LibCST...

Today `should_skip_file` is an instance method and hence requires the metadata wrapper, which in turn requires to parse the code. However, the two rules defining this method, only use the...

- [ ] Add a way to disable the `RemoveUnusedSuppressionsRule` - [ ] Standardize the flag for enabling disabling ignore comments. `apply_fix` uses `get_skip_ignore_comments_parser`, but `run_rules` uses `get_use_ignore_comments_parser`, which has...

The type definitions for `CSTTransform.on_leave` https://github.com/Instagram/LibCST/blob/df231f3fa5ac3dfa7b14a30103249e5da79509e3/libcst/_visitors.py#L50-L52 is too strict, as it requires that the return type is exactly the same as the original_node, which is not correct. For example, you...

machinery

The `matchers` module have functions that operate either just on the given node (`extract`), or in the node and its children (`findall`, `extractall`). However for `replace` there's no such distinction....

machinery

When doing replacements in a node, it's easy to end up with a tree, which won't get correctly converted to source code. The issue is that `libcst` is not adding...

Currently when you take a screenshot you get an image with a width equal to the viewport. That's not the best experience when taking screenshots of components, as there will...

pinned

In order to configure our i18n with `next-i18next` we had to first run a script to generate a JSON file, which we then load and pass it as props to...

pinned

When generating eval input I consistently get the following error: ``` hypothesis.errors.FailedHealthCheck: It looks like your strategy is filtering out a lot of data. Health check found 50 filtered examples...

Currently there's no support for `chrome.runtime.lastError`. After importing `sinon-chrome` what I'm doing is the following: ``` js chrome.runtime.lastErrorStub = sinon.stub(); Object.defineProperty( chrome.runtime, 'lastError', { get: chrome.runtime.lastErrorStub, set: function(value) { //...

enhancement