Sergio Rey

Results 208 comments of Sergio Rey

> Would any of you object this option? It is imho the best one. I would add "distinct" as a special case for the cmap argument to expose distinctipy colormap...

> The formula for Gaussian we use is this: > > def _gaussian(distances, bandwidth): > u = distances / bandwidth > return numpy.exp(-((u / 2) ** 2)) / (numpy.sqrt(2 *...

Adding a keyword arg would increase the clarity and allow for different use cases (i.e., kernels as proper pdfs, versus unnormalized kernels).

b works, but we also need to reflect the changes back in the spvcm package.

> I note we're now flipping negative theta over the x axis. Just to confirm: was the issue the signed `numpy.arctan`/`numpy.atan2`? > > We've gotta make sure this is remembered...

The enhancements have been added in a new PR #156. We can close this (unmerged) once that pr is reviewed, and if good, merged.

This is now integrated into #156

> > Can't say much about the Strauss process but we should revisit the seed/rng logic to follow SPEC7. > > @sjsrey – regarding Martin's comment here, from what I...

> > I can do this for pointpats, but I'm wondering if we want to revisit moving random tooling up into libpysal to ensure consistency throughout the federation? > >...

Looks like an older version of Sphinx is being used: ``` Running Sphinx v5.3.0 ``` whereas [libpysal](https://github.com/pysal/libpysal/actions/runs/9454509191/job/26042204462#step:5:9) (where docs build fine): ``` Running Sphinx v7.3.7 ```