Sébastien Doeraene comments

Results 632 comments of


                                            Sébastien Doeraene

Initial implementation of the WebAssembly backend.

Does cherry-picking https://github.com/sjrd/scala-js/commit/60a370112e2f79fa1daf339b41ec5148413ba395 solve the issue?

Initial implementation of the WebAssembly backend.

> Just as a reminder, I believe the comments on the README are not addressed yet. Yes, indeed. All my week was focused on being ready to present at the...

Initial implementation of the WebAssembly backend.

I believe I have addressed everything so far.

Initial implementation of the WebAssembly backend.

Rebased.

Initial implementation of the WebAssembly backend.

Well ... it turns out we didn't need Phase 2 of the bucket assignment algorithm at all! I added a few commits that should address the latest comments on that...

Initial implementation of the WebAssembly backend.

And I addressed the remaining comments that were not resolved yet, AFAICT.

Initial implementation of the WebAssembly backend.

Thank you so much @gzm0 for this epic review!

betterFors trailing `map` elimination can change the resulting type

I believe this one must be considered an intended source breakage. That for comprehension collapses to just `dog`. Under the new rules, if one wants to force a `map` that...

betterFors trailing `map` elimination can change the resulting type

It's obviously not an implementation detail, since it yields a different result type. 😉 It's at least a concern that could be brought back to the SIP committee for reconsideration.

betterFors trailing `map` elimination can change the resulting type

If it's a bug, it's a spec bug, because AFAICT the implementation is directly following the SIP. So changing it needs to back to SIP anyway. This is exactly the...