Sébastien Doeraene

Results 641 comments of Sébastien Doeraene

@gzm0 If I understood correctly your last comment, we can merge this now. Is that right?

sbt-scalajs is a plugin that other plugins depend on. What happens when you use an sbt plugin that depends on sbt-scalajs the traditional way but also enables this change? What...

> I hope I made a good case for it, but in case it is not acceptable, then I would like to work with you to resolve this specifically for...

We discussed this at the Scala Center and posted a renewed idea to fix this in sbt 1.x: https://github.com/sbt/sbt/issues/3410#issuecomment-1215043379 --- Unrelated: I also realized that `sbt-scalajs` *itself* depends on another...

I don't know. It's best to ask on the related sbt issue, I think.

This proves to be much more annoying than I expected, and it's not very important, so I'm pushing it further to v1.8.1.

@keynmol That sounds like a reasonable set to me. @nafg > I think there should be a few: If several are needed, then other people should maintain them. I cannot...

Last time I seriously looked at scalafmt for Scala.js, I came up with the following .scalafmt.conf: https://github.com/sjrd/scala-js/blob/scalafmt/.scalafmt.conf Maybe some of the things in there are worth including now. Also, maybe...

> Why did the AppVeyor build break? That failure is very weird. I've relaunched the build just because I can't make sense of it.

Well here the thing the optimizer sees is `if (XYZ == b)`. Collapsing that to `false` is hard.