Steve Riesenberg

Results 276 comments of Steve Riesenberg

No update @maradanasai. If anyone is interested in taking this up, see b6ec357 for one possible starting point.

Thanks everyone for so much valuable input on this issue! We have introduced simplified configuration via gh-11783 that allows for configuring a `RestTemplate` with proxy settings for OAuth2 Client components....

@mhalbritter I've added the imports and a few basic smoke tests.

Hi @mhalbritter! Just checking to see if there is any additional feedback on this PR? I'm especially interested in feedback related to the config properties. If there's any changes needed,...

@kcl-co > Maybe, we should use the protected convert method which used to convert `Authentication`. Hopefully I'm understanding you correctly, that you're suggesting we still consider a `protected` method that...

Hi @kcl-co, > i suggest include the detail setting, according to the define of AuthenticationConverter : I think that makes sense, thanks for suggesting it! > However, i feel it...

Hi @kcl-co! > should I switch branch upstream/5.6.x It's not really necessary. We can accept PRs against either the target branch (e.g. `5.6.x`) or `main`. It's not very reasonable to...

Hi @kcl-co! > Although we can do it, we forget that the method `getPreAuthenticatedPrincipal` and `getPreAuthenticatedCredentials` is a abstract method You are correct that setting a custom `authenticationConverter` would replace...

@kcl-co I don’t prefer to merge with merge commits and it would also be nice to squash commits. I can do this for you however, if it’s a problem for...