Sjoerd Talsma

Results 80 comments of Sjoerd Talsma

I agree with @yurishkuro. The suggestion of @jpkrohling sounds simple enough as a workaround. And you could further always use the `test-jar` dependency of `opentracing-util` as a last resort.

I don't know how to do that (I hope someone else can answer how to _not report_ fast spans). The `scope` should **always** be closed however, otherwise you risk having...

@felixbarny > Who is supposed that method in which circumstances? I can imagine some servlet filter right before returning the thread to the pool. Or a custom job scheduler, -again-...

Long time ago in the times of application servers and class loaders, I even went as far to create a list of all `static ThreadLocal` uses in our entire codebase...

The more I think about this, the more I tend to agree with Adrian. Scope is basically a container for `span()` that can be `close()`-ed. Access to the current scope...

@carlosalberto >>The close from anywhere is problematic. It should be controlled by the one activating the scope. >I think this could be easily 'enforced' by indeed not exposing Scope but...

I am creating a library called 'context-propagation' meant purely to propagate any (threadlocal) context implementation from a parent-thread to any background thread in a stack-like fashion, using the Autocloseable try-with-resources...

@bensigelman For what it's worth, I heavily depend on the the java.util.ServiceLoader to make my library pluggable. The abstract threadlocal implementation has the same 'linked stack' structure, except it tries...

@wu-sheng @adriancole , I pushed an initial attempt (with a working unit test using the MockTracer) to github yesterday evening: https://github.com/talsma-ict/java-globaltracer I would love to donate it to the 'contrib'...

@wu-sheng @adriancole I welcome feedback on the design and implementation choices by github issues. https://github.com/talsma-ict/java-globaltracer I'm also willing to transfer this repository to https://github.com/opentracing-contrib if you think this contribution is...