Samir Jha

Results 77 comments of Samir Jha

@ekohl Do we have any way of running nightlies against PRs? Is that a thing?

This seemed to be sufficient to drop the extension and upgrade: ``` UPDATE pg_extension SET extowner = (SELECT oid FROM pg_authid WHERE rolname = 'foreman') WHERE extname = 'evr'; ```

Thoughts on something like this: https://github.com/theforeman/foreman-installer/pull/955

Closing. This is not needed anymore. We rewrote the new migration with reviews from here: https://github.com/Katello/katello/pull/11159

This should fix the lint errors: `npx eslint --fix webpack/` This leaves only some `no-unused-vars` issues in 4 files..

Overall I am not seeing any issues so far in the code/testing. Minor notes I'll document in comments. 1. Notifications seem a little off: PF4: ![Screenshot from 2025-01-03 15-47-21](https://github.com/user-attachments/assets/376ecad1-bd7a-4b16-9dee-d815ed808ee2) PF5:...

For the conflicts here: webpack/scenes/ContentViews/Details/Versions/Delete/RemoveSteps/CVReassignActivationKeysForm.js, the branch code is right. For webpack/scenes/ContentViews/Details/Versions/Delete/RemoveSteps/CVVersionRemoveReview.js , The master branch has some logic which needs to be maintained. This looks like the right code...

The new changes work good..Notification is proper and sub-tab tables occupy full width. Noticed some weirdness in the global registration page, randomly the dropdowns show up like this: ![Screenshot from...

Locally, I am seeing only 7 failures, some nock ones and others where react test is failing to read by label text on 2 pages..Looking at those..Not sure what's causing...

The dropdown looks good now..Functionally seems to be in a good state..Looking into tests to see if they can be fixed locally..