Steven DeMartini

Results 119 comments of Steven DeMartini

This is somewhat related to this old PR that I never merged, since I wasn't confident in the approach https://github.com/sjdemartini/mui-tiptap/pull/109. I'm not totally sure the appropriate way to handle this...

Hm, I don't have any ideas how/why this would happen. It's the first I've seen this `colorSchemeSelector` approach to handling the palette mode (found docs here https://mui.com/material-ui/customization/css-theme-variables/configuration/#toggling-dark-mode-manually). (I'd previously only...

I've just published [v1.24.0](https://github.com/sjdemartini/mui-tiptap/releases/tag/v1.24.0) which switches to using `styled` instead of `tss-react`. Please let me know if upgrading happens to help with this, or if not, I can try to...

Thanks for detailing with the example repo; that's helpful. I was hoping to have (and believed I had mostly) resolved the ESM/CJS/NextJS troubles after https://github.com/sjdemartini/mui-tiptap/pull/270 (and explorations for https://github.com/sjdemartini/mui-tiptap/issues/256#issuecomment-2300004900) ....

It seems this issue in `y-prosemirror` is likely the culprit: https://github.com/yjs/y-prosemirror/issues/47. There seem to be 2 open PRs that would address the issue but neither have been merged.

> @sjdemartini I've made an additional PR as to those did not support the end-to-end usage that one would find in TipTap, such as TiptapTransformer.fromYdoc to convert the YDoc to...

Making that configurable was discussed a bit here https://github.com/astral-sh/ruff/issues/14892#issuecomment-2536960816, and it sounded like the preference is to hold off in favor of using type inference, once ruff supports that.

tldr: "custom" events with approaches like (1), (2), or (3) seem unnecessary if: a) `computed_fields` without setters could still have automatic event emission based on `field_dependencies` (this seems uncontroversially worth...

@tlambert03 nice, thanks! I appreciate you looking into and implementing this and following up. Unfortunately as of recently, I am no longer at the same company and am not working...