Suraj Sudhir comments

Results 39 comments of


                                            Suraj Sudhir

[mlir][tosa] Enhance TosaConvertTFLUInt8 pass to handle tosa.const with quant u8 values

I'd like to recommend @lhutton1 to review this.

Assertion when lowering from Torch IR for `AvgPool2d` when `kernel` is a tuple of a single int

If you're asking me to choose, 3 seems to be a good option.

Assertion when lowering from Torch IR for `AvgPool2d` when `kernel` is a tuple of a single int

I'm ok with either approach, since it matches documented behavior.

Decomposing `aten.as_strided` causes assertion failure in MLIR

@vivekkhandelwal1 @benvanik likely a TorchToLinalg problem but for an IREE user.

[linalg] : Use (-)realmax instead of (-)inf to avoid usage of non-finites.

Looks ok to me.

[Tosa] : Add support for negative indices in index.tensor and index.Tensor_hacked_twin for TorchToTosa lowering.

Hi @sahas3 thanks so much for this contribution! I took a quick look at this. I'm curious about whether this code can also have compile-time and run-time forms, with the...

[Tosa] : Add support for negative indices in index.tensor and index.Tensor_hacked_twin for TorchToTosa lowering.

Thanks, that looks pretty sane to me. Approving.

[TorchToTosa] Refactoring to separate construction of legal/illegal ops and conversion patterns.

I'll take a look within a day.

[TorchToTosa] Refactoring to separate construction of legal/illegal ops and conversion patterns.

Terribly sorry - I completely missed this PR! Please ping me on discord if you don't get a timely response from me. Reviewing this now.