Suraj Sudhir

Results 24 comments of Suraj Sudhir

The IR is really helpful to test against what I have and see if it legalizes right. I'll check today after morning meetings and post an update.

Just pushed https://github.com/llvm/torch-mlir/pull/1017 on this .

torch.constant.int is a known missing conversion.

I'll attempt to repro this early next week . Right now I'm trying to get a pipeline of pending BERT related legalizations out. Do you have detailed verbose output from...

What happens when you use 3, 4, 3 instead of -1, -1, -1 in the annotate args ?

Right, sorry for the delay. The experiment result appears aligned to my expectations, but I agree that if dynamic dims are unsupported then it should fail gracefully and not assert....

si64 should be acceptable to TOSA. It's not an I/O type but should permit accumulation. I'll check the dialect form; we may also have local fixes to get us around...

@silvasean and @JasonMaojinsong : The quantization_info meta information is constructed at compile time going from framework to TOSA. We would construct that in the TorchToTosa pass in this case. I...

Without looking at anything in detail, this sounds like something might have changed in TosaToLinAlg/LinAlgNamed/Arith that generates functionally wrong output, since the TOSA content is unchanged here.

Adding @eric-k256 and @u99127, as well as @jpienaar who has been reviewing recent TosaToXXX PRs . I think this might just be a git bisect away from catching which TosaToXX...