Szymon Janc

Results 177 comments of Szymon Janc

Hi, https://github.com/apache/mynewt-nimble/pull/1396 is an initial step to handle this (at some point we should remove fixed IRK and just use random)

I'm having trouble understanding this fix, this basically limit move_count to 255 what is exactly fixed here?

okay, so I looked at this and it appears that GCC is not able to properly track relations between globals (eg ble_store_config_num_peer_secs) and memmove in ble_store_config_delete_obj

I'd suggest to use assert() or if() to hint GCC BTW BLE_STORE_MAX_CCCDS() might have similar issues (if also configured to 1)

Hi, please check if https://github.com/apache/mynewt-nimble/pull/1737 solves this issue for you

Hi, This requires some explanation of design, functionality etc in commit message (and preferably split into multiple functional commits). Otherwise it might be hard to review 1.2k lines of code......

OK, so I'm not sure about this patch... spec clearly states that maximum attribute value shall be 512 and that data interpretation is responsibility of the higher layer. And offset...

Hi, service/gatt package provides this functionality via ble_svc_gatt_changed() have a look at https://github.com/apache/mynewt-nimble/tree/master/nimble/host/services/gatt If you implement GATT service on your own you may use ble_gatts_chr_updated() directly