jfreesane icon indicating copy to clipboard operation
jfreesane copied to clipboard

Published 20 hours ago • verified publisher icon sjamesr

Remove final from SaneOption

Open phablotassio opened this issue 5 years ago • 3 comments

Since final classes can't be mocked with regular mockito it's more useful to not be final.

phablotassio avatar Jul 19 '19 03:07 phablotassio

Pull Request Test Coverage Report for Build 306

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.036%
Totals Coverage Status
Change from base Build 272: 0.0%
Covered Lines: 923
Relevant Lines: 1139
💛 - Coveralls

coveralls avatar Jul 19 '19 03:07 coveralls

Pull Request Test Coverage Report for Build 306

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.036%
Totals Coverage Status
Change from base Build 272: 0.0%
Covered Lines: 923
Relevant Lines: 1139
💛 - Coveralls

coveralls avatar Jul 19 '19 03:07 coveralls

I don't have a problem with this change, but I'm not sure why you'd want to mock SaneOptions, unless you're also mocking interactions with the SANE server. It's best to interact with a real sane server if at all possible, even if it's one built with just the test backend.

Also, do you mind rebasing your change onto the latest HEAD? Thanks

sjamesr avatar Jul 19 '19 04:07 sjamesr