rspec_junit_formatter Show detail for failing examples using aggregate

Show detail for failing examples using aggregate_failures

Open jasoncodes opened this issue 5 years ago • 9 comments

Fixes #56

Example

Before

After

Note

There is a minor change to how backtraces are formatted. It’s now the same as what rspec shows when ran from directly:

Before

After

Oct 18 '19 04:10 jasoncodes

I am waiting for review and merge from owner

Oct 24 '19 09:10 xuantuan58

Sorry that this hasn't had attention in a while, @jasoncodes.

I really like this idea, but I'm very concerned that the parsing code seems to be a bit brittle and may break if future rspecs change output formats slightly. I'm not sure what the best answer here, which is why I haven't really jumped into it. 🤔

Apr 02 '20 06:04 sj26

What if I made the guards less strict so instead of raising on an unexpected format, they instead silently continue? This should at worst output a bit of duplication instead of erroring.

I’m not sure how to best add coverage for that though. Conditionally stub out fully_formatted_lines so it does something different than expected? Not sure if it’d be worth the effort.

Apr 05 '20 06:04 jasoncodes

@sj26 Sorry to bother, but do you have any further opinion on this?