six-webcomponents icon indicating copy to clipboard operation
six-webcomponents copied to clipboard

fix #175: add action-outline type to button

Open franckdervaux opened this issue 10 months ago โ€ข 1 comments

๐Ÿ”— Linked issue

#175

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • [ ] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [] ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • [x] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Add a new action-outline value for the type property of the button component.
The styling for this new type has been reviewed with Dimitris Papadopoulos.

Resolves #175

๐Ÿ“ Checklist

  • [x] I have linked an issue or discussion.
  • [x] It's submitted to the main branch
  • [x] When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • [x] I have updated the documentation accordingly.
  • [x] All tests are passing
  • [ ] New/updated tests are included
  • [x] I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • [x] A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

franckdervaux avatar Apr 25 '24 10:04 franckdervaux

@franckdervaux Please build (and commit) the docs by running npm run start:doc:fresh:full. If the updated docs aren't pushed, the pipeline fails because it detects that there are changes

davidemarcoli avatar Apr 25 '24 13:04 davidemarcoli

Added commit fixing the doc

franckdervaux avatar Jun 18 '24 13:06 franckdervaux