httpflow
httpflow copied to clipboard
six-ddc
Add Identity/Auth to template #300
Can you give me time till sunday?
On Thu, 13 Apr 2023, 7:14 pm Steve Smith, @.***> wrote:
@.**** requested changes on this pull request.
Overall looks great, thanks!
Only request is to don't put Identity stuff in Core (instead you can reference it using a UserId property on an appropriate entity, like in our case perhaps Contributor) and also keep IdentityDbContext separate from the regular/existing AppdbContext. Can you make those changes and I'll merge?
— Reply to this email directly, view it on GitHub https://github.com/ardalis/CleanArchitecture/pull/487#pullrequestreview-1383521649, or unsubscribe https://github.com/notifications/unsubscribe-auth/AILYWTSUSE4B4XJVZ7VJTBTXBAC5DANCNFSM6AAAAAATOEIRPM . You are receiving this because you authored the thread.Message ID: @.***>
I will try to complete it before sunday
On Thu, 13 Apr 2023, 7:31 pm Ahmed Anwer, @.***> wrote:
Can you give me time till sunday?
On Thu, 13 Apr 2023, 7:14 pm Steve Smith, @.***> wrote:
@.**** requested changes on this pull request.
Overall looks great, thanks!
Only request is to don't put Identity stuff in Core (instead you can reference it using a UserId property on an appropriate entity, like in our case perhaps Contributor) and also keep IdentityDbContext separate from the regular/existing AppdbContext. Can you make those changes and I'll merge?
— Reply to this email directly, view it on GitHub https://github.com/ardalis/CleanArchitecture/pull/487#pullrequestreview-1383521649, or unsubscribe https://github.com/notifications/unsubscribe-auth/AILYWTSUSE4B4XJVZ7VJTBTXBAC5DANCNFSM6AAAAAATOEIRPM . You are receiving this because you authored the thread.Message ID: @.***>
Great, thanks!
On Thu, 13 Apr 2023, 7:48 pm Steve Smith, @.***> wrote:
No rush, thanks
— Reply to this email directly, view it on GitHub https://github.com/ardalis/CleanArchitecture/pull/487#issuecomment-1507105133, or unsubscribe https://github.com/notifications/unsubscribe-auth/AILYWTXEQ3IDQCFZWGXRBF3XBAG3LANCNFSM6AAAAAATOEIRPM . You are receiving this because you authored the thread.Message ID: @.***>
My plan is still to pull this into the new template - just need to find some time.