httpflow icon indicating copy to clipboard operation
httpflow copied to clipboard

Add Identity/Auth to template

Open ardalis opened this issue 3 years ago • 11 comments

The default template should support default Identity.

I don't recommend having both cookie- and token-based auth in the same project, so I will probably start with just token support.

ardalis avatar Dec 17 '21 02:12 ardalis

I want to work on it, please assign it to me

ahmedanwar100 avatar Oct 21 '22 18:10 ahmedanwar100

All yours. Realize that we are making some substantial changes for .NET 7. Go ahead and add JWT token auth to the current main branch (net6) version and we can hold off on adding it to the net7 version until after net7 ships.

ardalis avatar Oct 21 '22 18:10 ardalis

@ardalis can you please review it Add Identity/Auth to template #300

ahmedanwar100 avatar Jan 03 '23 18:01 ahmedanwar100

@ahmedanwar100 I reviewed your PR. It looks good and I would like to incorporate it in the solution I am developing. Would you be willing to help me do that. I'd be happy to compensate you for your time and effort.

FlorianHoornaar avatar Mar 29 '23 10:03 FlorianHoornaar

sure @FlorianHoornaar

ahmedanwar100 avatar Mar 29 '23 11:03 ahmedanwar100

@ahmedanwar100 can you resolve the conflicts now that we're on net7 and I'll try to merge this in this week?

ardalis avatar Apr 10 '23 21:04 ardalis

Ok, that's great

On Tue, 11 Apr 2023, 2:34 am Steve Smith, @.***> wrote:

@ahmedanwar100 https://github.com/ahmedanwar100 can you resolve the conflicts now that we're on net7 and I'll try to merge this in this week?

— Reply to this email directly, view it on GitHub https://github.com/ardalis/CleanArchitecture/issues/300#issuecomment-1502357308, or unsubscribe https://github.com/notifications/unsubscribe-auth/AILYWTQBPFZW436H3YUC6HDXAR4E3ANCNFSM5KHX3Y7A . You are receiving this because you were mentioned.Message ID: @.***>

ahmedanwar100 avatar Apr 10 '23 22:04 ahmedanwar100

I've looked at the pull request and seen comments from @ardalis which suggested moving the customer IdentityUser and IdentityRole implementations from Core to Infrastructure. I don't disagree with this, but if I wanted to fire Domain Events when a new user is created or logs in... where would those events live? Do they belong in Core? In Infrastructure?

Is the Infrastructure project the correct place for a UserAggregate folder similarly to the ProjectAggregate folder in core?

DerekChasse avatar May 02 '23 18:05 DerekChasse

@ardalis can you please clear it out and please take a look at the PR so it can be merged Thanks

ahmedanwar100 avatar May 02 '23 18:05 ahmedanwar100

@DerekChasse @ardalis Is this feature added or can I work on this?

raihanmehran avatar May 20 '23 02:05 raihanmehran

This feature is already implemented, just a review from @ardalis is required

ahmedanwar100 avatar May 20 '23 03:05 ahmedanwar100