siwapp-ror icon indicating copy to clipboard operation
siwapp-ror copied to clipboard

API RF: Improve the way nested relationships are stored

Open ecoslado opened this issue 7 years ago • 6 comments

I've changed the API to implement JSON API Standard. I used ActiveModel Serializers to do that, but I didn't find the way to make the serializer to store nested relationships in objects. So, in commons_controller.rb, I add every relationship explicitly: https://github.com/siwapp/siwapp/blob/master/app/controllers/api/v1/commons_controller.rb#L49

Look for a cleaner solution.

ecoslado avatar Nov 03 '16 11:11 ecoslado

@ecoslado why not use Fast JSON Api?

dnwilson avatar Jul 18 '19 12:07 dnwilson

That could be definitively a good option. Right now I'm working on upgrading to Rails 5, but after that this could be done.

peillis avatar Jul 18 '19 14:07 peillis

@peillis I have a forked Rails 5.2 version in production

dnwilson avatar Jul 18 '19 16:07 dnwilson

Great! but where is the code? I can't see any of it in your account.

peillis avatar Jul 19 '19 12:07 peillis

I made it private because I added additional ERP functionality and commit confidential information by accident but I'll make a PR for the 5.2 portion of the upgrade

dnwilson avatar Jul 19 '19 18:07 dnwilson

Dont worry about it, I have the work almost done. Thank you

El vie., 19 jul. 2019 20:03, Dane Wilson [email protected] escribió:

I made it private because I added additional ERP functionality and commit confidential information by accident but I'll make a PR for the 5.2 portion of the upgrade

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/siwapp/siwapp/issues/202?email_source=notifications&email_token=AADQR3NWEF3LVNBN5OVZZWTQAH6YLA5CNFSM4CVBA4A2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2MK5XA#issuecomment-513322716, or mute the thread https://github.com/notifications/unsubscribe-auth/AADQR3NH3EMEKXK7KYQZD7LQAH6YLANCNFSM4CVBA4AQ .

peillis avatar Jul 19 '19 19:07 peillis