node-statsd icon indicating copy to clipboard operation
node-statsd copied to clipboard

Is sampleRate required for .increment?

Open briansorahan opened this issue 10 years ago • 1 comments

> var StatsD = require('node-statsd').StatsD;
undefined
> var client = new StatsD();
undefined
> client.increment('foo', 1, function() { console.log('fin'); })
undefined
> client.increment('foo', 1, 1, function() { console.log('fin'); })
undefined
> fin

undefined
>

I waited a few seconds after the first call to increment, and callback was never invoked.

Using 0.0.7

I'd be happy to create a PR to update README with more detailed info about which args are optional/required for each method exposed by StatsD, if you're interested.

briansorahan avatar Aug 22 '14 18:08 briansorahan

this shouldn't be the case. the api for all calls should be the same.

devdazed avatar Aug 26 '14 15:08 devdazed