speedtest-cli icon indicating copy to clipboard operation
speedtest-cli copied to clipboard

Remove break in `get_servers`

Open engrbm87 opened this issue 2 years ago • 4 comments

Remove the break in the get_servers method so that we can get the list of servers from all urls.

engrbm87 avatar Aug 29 '22 10:08 engrbm87

Thanks for submitting this. I was going to look for this exact problem. It resolves a key issue for me of not getting local area servers in the returned list.

wriba avatar Sep 23 '22 08:09 wriba

Hello @sivel , any chance we can get this merged please.

engrbm87 avatar Nov 10 '22 11:11 engrbm87

I just noticed this issue too, I was wondering why speedtest-cli was not giving as good server alternatives as in other clients and found the break, should have looked at the pull requests first lol. Hopefully can be merged.

sinnet3000 avatar Apr 29 '23 19:04 sinnet3000

Just ran into this myself, was confused why two different systems and networks physically separated by only about a kilometer not only had very different lists but they also would refuse to run against server IDs not in their lists (which was making meaningful comparisons tricky!).

This line removal seems to entirely solve that, with many more servers now listed and reachable, although I note that the list shown via --list now has most (though fascinatingly not all) entries duplicated.

keithzg avatar May 25 '23 23:05 keithzg