sivchari

Results 132 comments of sivchari

I rebased and fixed some review points. Thanks.

The list that I should write UnitTests - [x] handleGithubErr - [x] (g *gitHubRepository) getVersions - [x] (g *gitHubRepository) handleGithubErr - [x] (r *KubeadmControlPlaneReconciler) Reconcile

It sounds good, then if we decide to use it, we might be able to drop the direct dependence of pkg/errors completely.

Sure, I'd give you some steps to reproduce 👍

Hi, @sanposhiho Since I wanna assign many pods to node, I edited allocatable and capacity in /status. But the changes weren't applied. This change can be made in kubectl, not...