sivborg
sivborg
Thank you for taking a look through! Regarding not being capable of editing existing polygons, an earlier commit actually had that possibility! However it used some "private" features in the...
It is mostly a problem in the case where you have multiple polygons. It is possible to attach multiple `PolygonSelector`, however using several in one plot can make things very...
I am working on reimplementing an older commit where there was only one polygon in the ROI, for consistency. I am a bit busy currently but hope to have it...
Thank you for the consideration, @ericpre! However there is not too much to be done, so I can handle this myself once some more time opens up, which should not...
Hello, I have some time now to finish up this PR after a busy spring and some LiberTEM development, so I have been implementing the final details. Another functionality I've...
I have now implemented slicing with combined `PolygonROI`s! This works as follows: ```python print(s) # roi = hs.roi.PolygonROI(((5,0),(120,0), (0,120))) roi2 = hs.roi.PolygonROI(((150,180),(30,130), (180,0))) roi3 = hs.roi.PolygonROI(((220,160),(160,160),(160,220), (220,220))) sliced = roi.combine(s,...
Now the functionality of this PR seems to be at the place where I want it. So what remains for me is to take another close look, then this PR...
@ericpre The PR should now be ready to review! It is mostly the `PolygonWidget` class I am unsure of, so would be great with a look there. Some code to...
Yes, I agree a refactoring might be necessary. It is hard to make `RangeWidget` and `PolygonWidget` have common ancestry due to the former inheriting from other base classes with added...
I have now refactored and removed the `MPLWidgetBase` class. So it should be ready to merge in this state, but I can also take some time later to look into...