Custom-Fee-Magento2 icon indicating copy to clipboard operation
Custom-Fee-Magento2 copied to clipboard

Published 20 hours ago • verified publisher icon sivajik34

composer changes

Open jaykobi opened this issue 8 years ago • 1 comments

Hi,

first of all a big thank you for uploading that module! I already use it and it does it's job well.

To make it installable with composer directly you should have composer.json in the root directory. In fact, I think best practice is to put alle the code you now have under Sivajik34/CustomFee in the root directory directly. Composer will take take of creating those directories during installation.

Also the dependency for magento framework is out of date ("magento/framework": "~100.0.4"). I just installed with magento 2.1.3 and it worked so you should consider updating this, or composer will not let anybody install it.

Thanks for the great work.

jaykobi avatar Feb 14 '17 15:02 jaykobi

Thank you for your feedback,i don't have enough time to work on this.you can contribute by forking the repo,make pull request.

sivajik34 avatar May 09 '17 14:05 sivajik34