throttle Don't set `down` to 780 if not given

Currently the command line and API is "all or nothing", meaning that if a parameter is not give (e.g. down) then a default value for it is chosen (in this case const defaultDown = 780).

Is there any reason to not force all values to be given and let some of them just unset (without a max value)?

Apr 22 '19 17:04 ibc

Hi @ibc no I don't think there's a reason, it just happened :) I agree it could be forced.

Best Peter

Apr 23 '19 08:04 soulgalore

Thanks. The thing is that, at least in my use-case, I want to limit uplink or bandwidth, and usually not both. And when I want to limit uplink I do not want to also limit downlink to some default value.

And chance to implement this behavior? :)

Apr 23 '19 15:04 ibc

It also seems that rtt could be splitted into downDelay and upDelay (instead of assuming that the given rtt must be divided by 2 and applied to both down and up.

Apr 23 '19 15:04 ibc

I've fixed so you can set just one parameter (but you need to set at least one). For changing RTT, yeah maybe if we can make it backward compatible. I can test a PR for it if someone has the time.

Apr 12 '21 13:04 soulgalore