sitespeed.io icon indicating copy to clipboard operation
sitespeed.io copied to clipboard

[Documentation] S3 Expire, incorrect description

Open Amerousful opened this issue 1 year ago • 1 comments

Feature/improvement

Hello there! According to the documentation, to set the expiration date for S3, we should set a timestamp after how long files will be deleted, but in fact, this param Expires is about when files will be deleted. -s3.params.Expires=31536000 to set expire to one year. it sets for AWS S3 Friday, January 1, 1971 00:00:00 GMT image 1934

Thus, for proper expiration time, we have to do something like this: -s3.params.Expires=$(($(date +%s) + 31536000))

Links on the documentation where mention it: https://www.sitespeed.io/documentation/sitespeed.io/s3/#extra-configuration https://www.sitespeed.io/documentation/sitespeed.io/configuration/

Amerousful avatar Feb 05 '24 12:02 Amerousful

i want to work on this issue?

narasimha-1511 avatar Feb 06 '24 10:02 narasimha-1511