sitespeed.io icon indicating copy to clipboard operation
sitespeed.io copied to clipboard

Influx Cloud (v2) support

Open danielloader opened this issue 3 years ago • 4 comments

I've read the documentation and other issues on here, and I've noticed in this reply that sitespeed leverages the node-influx package for connectivity with influxDB.

However node-influx aren't advertising compatibility with InfluxDB 2, suggesting to use the official influxdb-client-js package instead. (https://github.com/node-influx/node-influx/issues/483#issuecomment-597657588)

Is this on the roadmap to support the new influxdb client library? Thanks

danielloader avatar Nov 24 '20 15:11 danielloader

Hi @danielloader ah cool, I'm no InfluxDB user so I haven't noticed there's a new version. I'm busy with work for the rest of the year that has higher prio for me, but I can help out if someone wanna make a PR.

Best Peter

soulgalore avatar Nov 25 '20 11:11 soulgalore

+1 for this. Unfortunately I cannot help with code but I would love to help by testing etc.

ahoiroman avatar Apr 19 '21 18:04 ahoiroman

@ahoiroman can you help check if its backward compatible? I can do the switching to the new version but my guess is that it will break for people running older influx or will that not be an issue, I haven't investigated.

soulgalore avatar Apr 19 '21 19:04 soulgalore

As far as I know it's not - the read-API kinda is, but the write is not. But maybe a switch could be added (--influx-version)?

ahoiroman avatar Apr 19 '21 20:04 ahoiroman