sitespeedio
visualmetrics with "carousel" element
Visualmetrics last visual change for https://www.kaalimato.com/ is ~25s because the carousel keeps changing the page - is there any way to mitigate this?
You can choose when to end your test with https://www.sitespeed.io/documentation/sitespeed.io/browsers/#choose-when-to-end-your-test
hmm, but wouldn't a better solution be some sort of --visuallyCompleteIfNoChangesDuring 2.0 ?
The video doesn't decide when to end, it just record the screen. My guess in your case that the loadEventEnd hasn't fired (not all request/responses are done). What happens on screen isn't the same as which requests being handled by the browser.
Yeah, the page keeps loading with every single carousel page. I still think it should be possible to not write custom handler every page. I'll think about this.
It works like this: You can run your own JS that decides when to end. But by default WebDriver gives back control after loadEventEnd happens, so you need to change the --pageLoadStrategy so you get into control direct after the navigation.
But loadEventEnd happens at 1.54s, "fullyLoaded" happens at 30s (timeout?) - So I don't think it's about pageLoadStrategy -- the control is returned with normal strategy?
Then I would guess that we stop the video after we collected all the JS metrics, instead of do it before. Need to check the implementation.
I think we could change it but it needs some changing/splitting the code. Today we need to know the URL from the page when we stop the video, that need to be fixed. Then we could close the video right before we stop collect metrics using JS. But it will need some testing to make sure we don't introduce new things. Moving this to Browsertime since its there it needs to be implemented.
I looked into it now, since we have the same problem at work. Well, it would need quite many changes and I don't see this happening any time soon.
what kind of changes? if you help me out a bit, maybe I could try to do a PR?
Ooops I looked at the wrong place, fixed now at least the best we can do, lets see what kind of impact it will have.
The way I would fix this is to add a custom --injectJs to that page that actually blacks out the carousel element. Seem more and more people using this approach to "black out" ads so you do not measure them in the visual metrics.