issue with the new version

[frozeman]

you need to add

      , tabs1       :{}

to the line 732, otherwise i get errors in IE

[siteroller]

Am hoping to push a change to that part of the code today.

However, which version of IE, and what platform? I haven't even gotten up to testing IE yet. Thanks.

And OT: Thanks for those icons about a month ago. Once this is somewhat stable, I would like to add them, overall your graphics rock.

[frozeman]

i used IE9 on windows 7

but it seemed also to come up in safari.. the problem was because tab1 didnt returned an object this caused problems from line 389 on...

Liebe Grüße Fabian

On 30.05.2012, at 11:48, SamGoody wrote:

Am hoping to push a change to that part of the code today.

However, which version of IE, and what platform? I haven't even gotten up to testing IE yet. Thanks.

And OT: Thanks for those icons about a month ago. Once this is somewhat stable, I would like to add them, overall your graphics rock.

---

Reply to this email directly or view it on GitHub: https://github.com/siteroller/moorte/issues/41#issuecomment-6006067

[siteroller]

Please pull the last changes and try again. Note that I have no tried it myself in IE. And that this is a moving target.

[frozeman]

issue seem to fixed, but a new one came up

i have $('editablePageTitle').moorte({location:'none'});

and when i click the editable area it get an error because line 275:

, updateBtns: function(e){
    var val
      , update = MooRTE.activeBar.retrieve('update');

update = null

so i just add

if(update === null) return;

below so it over jumps that function

[frozeman]

ps, you also forgot to remove a console.log()

[frozeman]

sorry more errors: line 321 var event = MooRTE.Elements[name][onEvent];

onEvent is sometime 'undefined'

so i add before if(typeOf(onEvent) === 'null') return;

[siteroller]

Its not throwing any errors by me - and I dont see why that should. But you are right that we should be checking if there is any event to call. Hopefully in tomorrows changeset.

Nonetheless, I suspect that if you are getting errors, there is a bug there

• which page and which browser?

On Wed, May 30, 2012 at 11:51 PM, Fabian Vogelsteller < [email protected]

wrote:

sorry more errors: line 321 var event = MooRTE.Elements[name][onEvent];

onEvent is sometime 'undefined'

so i add before if(typeOf(onEvent) === 'null') return;

---

Reply to this email directly or view it on GitHub: https://github.com/siteroller/moorte/issues/41#issuecomment-6020981

[frozeman]

i got this error when setting no moo rte toolbar but make an area editable