Sitegeist.Archaeopteryx icon indicating copy to clipboard operation
Sitegeist.Archaeopteryx copied to clipboard

BUGFIX: Prevent the node editor from breaking for nodes with hashes

Open rolandschuetz opened this issue 4 months ago • 4 comments

Fixes #59

rolandschuetz avatar Apr 10 '24 20:04 rolandschuetz

This will show links like node://XXXXXX#section as they are without resolving the node, right? At least the editor can be used for such links, but IMO the main goal should be to see the selected node, too. Nevertheless, this is way better than the current behavior. But the same check should then be used for assets, too.

Benjamin-K avatar Apr 11 '24 04:04 Benjamin-K

Exactly, since there was no decision on how the UI should look, this is just a bugfix preventing an internal server error and broken UI.

rolandschuetz avatar Apr 12 '24 08:04 rolandschuetz

Could you add asset:// links with hashes to this PR, too? That would be awesome!

Benjamin-K avatar Apr 12 '24 09:04 Benjamin-K

@Benjamin-K Makes sense, I added it together with some tests

rolandschuetz avatar Apr 22 '24 21:04 rolandschuetz