linkding icon indicating copy to clipboard operation
linkding copied to clipboard

Add active states to top-level nav menu items

Open 1ockwood opened this issue 1 year ago • 1 comments

Changes

This is a fairly simple change that adds active states to the top-level nav menu items on large viewports. As a new user, the first time I clicked around, I expected to see that sort of feedback to give a sense of where I am in the app.

I kept it to the "desktop" version of the nav menu only, as the "mobile" menu is structured a bit differently (the top-level "Bookmarks" item being grouped at the same hierarchy as the other Bookmarks entries), and I don't necessarily feel it needs the same feedback in that context. Happy to experiment with that though if you feel otherwise.

In the same vein, I also tweaked the styles for hover states for the nav menu links.

Screenshots

Dark Mode

nav-menu-active-items-dark

https://github.com/user-attachments/assets/8359c87c-d4c5-4d63-a284-ed48cb78be42

Light Mode

nav-menu-active-items-light

https://github.com/user-attachments/assets/ec1a5deb-9213-4b12-ab16-2a01ad776c82

1ockwood avatar Nov 12 '24 02:11 1ockwood

I love this! Any chance to merge?

tkafka avatar May 13 '25 09:05 tkafka