sissbruecker
Improve tags suggestions
Now tags support two methods of matching:
-
static- which loads all tags when requested and keeps them in cache until next reload -
dynamic- which loads tags from backend
Other than that it also supports two methods of matching tags:
-
stars_with -
contains
These setting are controlled with following environmental variables:
-
LD_TAG_FETCH_TYPE -
LD_TAG_MATCH_TYPE -
LD_TAG_MINIMUM_CHARACTER
So with this MR, i wanted to solve two problems - that i feel are somewhat interconnected.
First one: ability to search that tag contain some string instead of searching that tag starts with some string. I feel like i shouldn't be forced to remember where i put my string (at the start, in the end or in the middle), since software can keep track of it.
Second one, is to offload searching - at least as an option - to backend. My reasoning for it:
- usually backend is more equipped to handle this type of task
- by moving it to backend, frontend can do less work, and because of that be more efficient (speed and power and bytes transferred)
But right now I'm looking that my local instance is returning only 6 KiB of tags. So this change might not be needed.
I think for most use-cases / regular usage the current approach is perfectly fine. I'm not up for maintaining two versions of the tag filtering to potentially save a few kB being transfered in most cases. If filtering stays on the client-side, then I don't see the need for adding a restriction on the number of characters as well.
I'm fine with adding an option for a contains-type search though. If you want to proceed please make it an option in the user profile that can be toggled through the UI / settings.
