Simon Eskildsen

In a follow-up we'll have to figure out how to make this part of [Instrumentable](https://github.com/Shopify/semian/blob/master/lib/semian/instrumentable.rb) so we can monitor the circuit breaker stats across all hosts.

\cc @charliesome @jnunemaker you'll be interested in this for your adoption.

So to sum up my initial code review, questions/changes I'd like to see are: - Merge as much code as possible with `semian.c` and compile them into the same shared...

@kyewei is going to split this into some smaller PRs since this is too hard to review.

Do you mean for the circuit breakers? I would assume that increasing the size of the window (timeout) would cause this to decrease since there should be some randomness involved...

HAProxy has poor support for on-the-fly reloading (by dropping connections). HAProxy is more suited for situations that require load balancing and/or health checking (eg Airbnb's smart stack), which Semian doesn't....

ya of course :) I'll be sure to do a talk on this next time I'm in Aarhus.

Yeah, it was not designed to be `thread_safe` (we haven't needed it), but it definitely makes sense for it to be. 👍 to @casperisfine's direction.

This is similar to what we did back in 2014 for Resiliency, albeit through mocks, not the application library. However, it assumes that the circuits are perfectly implemented and that...

@supantha nope, feel free to add one. We don't use Postgres at Shopify--so we haven't needed it, but I'm sure other users of Semian would appreciate it :)