parboiled icon indicating copy to clipboard operation
parboiled copied to clipboard

Published 20 hours ago • verified publisher icon sirthias

Library is not OSGi-compliant

Open pshirshov opened this issue 9 years ago • 4 comments

You should OSGify library. It's easy with typesafe sbt-osgi plugin.

Here is example: https://github.com/typesafehub/scala-logging/pull/37/files

pshirshov avatar Jul 27 '15 22:07 pshirshov

Also stumbled upon this - note that the OSGi manifest informations were there in previous versions, e.g. 1.1.6 of parboiled-java includes the headers, 1.1.7 does not. Just wrapping with default settings is probably not enough, for me it was important that parboiled-java is a fragment of parboiled-core (Fragement-Host header). For parboiled-scala probably the same applies.

stempler avatar Jun 01 '16 12:06 stempler

OSGi support is increasingly a non-goal for me. Establishing and maintaining it properly is not something that I am sufficiently qualified for. Also, my impression is that the share of users that depend on or ask for it is steadily decreasing. Sorry guys...

sirthias avatar Jun 01 '16 15:06 sirthias

Just for the record, I was also effected by the lack of OSGi support in 1.1.7.

bdkent avatar Jun 13 '16 19:06 bdkent

PR #132 fixes a class loader problem with ASM ClassWriter to use Parboiled 1.3.0 in OSGi containers.

I would suggest to create a single OSGi bundle for the Java version as in https://github.com/komma/komma/blob/15aa9321d0f2e7a2f29f6677ed6b5f296505415f/libraries-p2/parboiled/pom.xml

This avoids problems with fragments (Fragment-Host header) or split packages...

kenwenzel avatar Mar 15 '19 07:03 kenwenzel