fastify-graphql icon indicating copy to clipboard operation
fastify-graphql copied to clipboard

Move to apollo-server repository

Open jeromemacias opened this issue 7 years ago • 6 comments

Should be really cool to see https://github.com/apollographql/apollo-server/issues/626 fixed using this repo.

As you already done switch to TypeScript, it seems to be on the road of apollo-server-fastify ;)

Thanks for your works and @coopnd one !

jeromemacias avatar Feb 06 '18 13:02 jeromemacias

There's a few small things that need to be done before I'd consider this ready for a move to apollo-server. I'll get things polished over the next few days and drop you a mention once things are good to go.

sirsavary avatar Feb 06 '18 20:02 sirsavary

Thanks! Can I help you ?

jeromemacias avatar Feb 06 '18 21:02 jeromemacias

@jeromemacias I think I'll be alright to clean the code up myself. I'm going to borrow the apollo-server-express test suite and make sure that this middleware is compliant with it. Once that's done I'll ping you and we can start migrating it into apollo-server.

sirsavary avatar Feb 11 '18 23:02 sirsavary

@jeromemacias Just thought I'd let you know that AFAIK this plugin should now be on par with the other Apollo middlewares as of 42f18e846d23fdb8b87757b49cec80abc6c55c2e

sirsavary avatar Mar 05 '18 16:03 sirsavary

Thanks for helping out my lazy ass. This has been a long time coming....

ghost avatar Mar 08 '18 04:03 ghost

Seems someone else is working on it the past 2 weeks if you 2 want to help?

tomByrer avatar Oct 12 '18 01:10 tomByrer