alphastone icon indicating copy to clipboard operation
alphastone copied to clipboard

which CardDefs.xml do you use?

Open 1576012404 opened this issue 5 years ago • 2 comments

it seems that some cards in CardDefs.xml are not implemented in fireplace,so which vision of CardDefs.xml do you use?

the link:https://github.com/HearthSim/hsdata

1576012404 avatar Jul 18 '19 14:07 1576012404

I used the standard CardDefs.xml, but I only trained with the core/basic card set. There's a function in gameUtils.py that allows you to exclude all cards in training except for a specified set https://github.com/sirmammingtonham/alphastone/blob/06e633b4b750c002d2d488334aa75b292482651d/alphabot/utils/gameUtils.py#L26-L35 so the non-implemented cards are ignored. This will be called if is_basic=True. Hopefully fireplace is still being worked on so more cards can be implemented soon.

sirmammingtonham avatar Jul 20 '19 07:07 sirmammingtonham

i run the code with default parameters,so it use the notbasicset files of yours. i can also finds some cards whose effects are not implemented.

1576012404 avatar Jul 21 '19 06:07 1576012404