sirix icon indicating copy to clipboard operation
sirix copied to clipboard

Fixing and enhancing documentation

Open JohannesLichtenberger opened this issue 4 years ago • 18 comments

Fixing typos and/or grammar, mark unclear sections.

Maybe if you try out SirixDB you could even add a sentence, a section or even write a tutorial or a blog post if yoh like it :-)

JohannesLichtenberger avatar Sep 26 '19 19:09 JohannesLichtenberger

Can I help with this?

elizabethqiu avatar Oct 25 '20 05:10 elizabethqiu

Sure, would be great :)

JohannesLichtenberger avatar Oct 26 '20 00:10 JohannesLichtenberger

Let me know if you need help :+1:

JohannesLichtenberger avatar Oct 27 '20 13:10 JohannesLichtenberger

Thank you! I would love receive a bit more clarification on how to get started. (I have basic coding skills, but am not confident on overall skills)

elizabethqiu avatar Oct 30 '20 16:10 elizabethqiu

hi @elizabethqiu, that's great. You can for instance try to get the web GUI up-and-running and work on the documentation.

You can also try to run the (mostly) Java based, or Kotlin based unit/integration tests in IntelliJ. Or you might try to use the Python-Client for instance.

JohannesLichtenberger avatar Oct 30 '20 22:10 JohannesLichtenberger

I hope this helps :)

JohannesLichtenberger avatar Nov 05 '20 11:11 JohannesLichtenberger

Hi @JohannesLichtenberger is this issue still open ?

adnanmorsy97 avatar Apr 14 '21 10:04 adnanmorsy97

Yes, still open

JohannesLichtenberger avatar Apr 14 '21 10:04 JohannesLichtenberger

@JohannesLichtenberger Perfekt! Can you please assign me to this issue. Thank you :)

adnanmorsy97 avatar Apr 14 '21 10:04 adnanmorsy97

Hey @JohannesLichtenberger, I have read your documentary and found some spelling and grammar mistakes. I have already forked your project and would like to know what my next steps should be. I have noticed, that there is a link in the documentary where I can do some changes in the documentary. Should I use this link ? Do I need to create a new branch for this issue ?

adnanmorsy97 avatar Apr 26 '21 15:04 adnanmorsy97

@adnanmorsy97 unless you have permissions to the repository, you would not be able to make changes without forking and creating a PR. That being so, I don't believe that you would be able to commit changes using that link. It simply takes you to an editing page, and it will probably create a fork for you when you wish to save your changes.

mosheduminer avatar Apr 26 '21 15:04 mosheduminer

@mosheduminer thanks for your answer. That means, that I should use the link and after I did some changes in the documentary, I should create a PR ?

adnanmorsy97 avatar Apr 26 '21 15:04 adnanmorsy97

Honestly, I'm not sure exactly how the link works. I assume that if you try to save changes through that link, it will automatically show you a page to create a PR. So if you want to, sure, use the link.

mosheduminer avatar Apr 26 '21 15:04 mosheduminer

Yes, I believe what @mosheduminer wrote is true :-)

JohannesLichtenberger avatar Apr 26 '21 17:04 JohannesLichtenberger

Hey @JohannesLichtenberger, I have read the entire documentation and fixed all the mistakes, that I have found. I also made a PR. You can find my work in the following links:

  1. https://github.com/sirixdb/sirixdb.github.io/pull/14

  2. https://github.com/sirixdb/sirixdb.github.io/pull/16

  3. https://github.com/sirixdb/sirixdb.github.io/pull/17

  4. https://github.com/sirixdb/sirixdb.github.io/pull/18

  5. https://github.com/sirixdb/sirixdb.github.io/pull/19

Could you please merge them ? I would be very happy if you did that.

However, I have noticed some grammar and spelling mistakes in the “DOM ALIKE” and “PYTHON SDK API” documentary, but I can’t find a link for these two! What should I do ? Is there another way to make changes in the documentation instead of using the link or could you perhaps add the link for these two ?

I hope you liked my work and would like to know if you have any further suggestions or improvements for me ? 😊

adnanmorsy97 avatar Apr 27 '21 18:04 adnanmorsy97

can i work on this issue

Rishavgupta12345 avatar Sep 30 '21 06:09 Rishavgupta12345

is this issue still open

Sanket-777 avatar Oct 03 '21 05:10 Sanket-777

sure, it's still open :)

JohannesLichtenberger avatar Oct 03 '21 22:10 JohannesLichtenberger