sirix
sirix copied to clipboard
sirixdb
Changed and added commands in docker files
Thanks so much for opening this pull request and for helping to improve SirixDB 🚀
![welcome[bot] avatar](https://avatars.githubusercontent.com/in/4141?v=4 "Published by a pub.dev verified publisher"){kind=small}
Oh, what's this about? I thought it's Keycloak updated somehow
Hello! So these changes help the container keycloak to not start and exit immediately and when i altered these i was also able to build successfully the build.gradle from the folder sirix-rest-api.
The thing is that the docker compose file in the root dir should build a new image from the sources (afterwards it's pushed to docker hub for use by the rest api bundle and for everyone).
Do you mean the sirixdb/sirix image? If you mean this image i build it with a command and then i was able to use it . Also both ports (the 8080 and 9443) are accessible and then i tried the python sdk api to see if it actually works.
| Okay so i added this command and executed it again.From the reports that are produced i see this. Package | Tests | Failures | Ignored | Duration | Success rate |
|---|---|---|---|---|---|
| io.sirix.rest | 66 | 0 | 0 | 19.163s | 100% |
| So can you please explain what is the problem with the sirix-rest-api because i see all the containers are running smoothly. Maybe i dont understand something. Thank you and sorry for the trouble. |
The docker compose file in sirix-rest-api uses the most recent version from docker hub, which is built before via the docker compose file in the root directory of the project. I'm still not really sure what's the problem you're facing. So, using the docker compose script in sirix-rest-api starts keycloak and stops it immediately?
Sorry for the confusion! I saw on the issue #711 this,The container doesn't start using the newest image,and also on the issue #707 that the tests fail. I think that these changes might help with these issues.
Oh, #707 was fixed (the keycloak image only exists for quay.io). Idk what's wrong when updating Keycloak to the newest version, though. In any case, if your changes help, we could add the local build again, I guess, regarding the root docker compose file!? Otherwise it wouldn't be updated anymore (and pushed to docker hub).
If my changes prove effective, I will add the local build option in the root Docker Compose file again.Thank you and sorry for the confusion!
Could you please clarify what specific steps you'd like me to take regarding the Keycloak update? Should i investigate the issue further or add the build . in the root file and check this?
You'd have to update the Keycloak version as well (also add build . again, as it's mandatory to do a local image build)