sirix icon indicating copy to clipboard operation
sirix copied to clipboard

Inconsistencies in GET request in ACCEPT header

Open redwanulsourav opened this issue 1 year ago • 2 comments

Not sure if this is accepted behavior or a bug. I found this out when testing the REST API with curl.

For inserting resource, if a GET request is sent to path /<database_name>/<resource_name> with no ACCEPT header set, it by default assumes a JSON database. If <database_name>/<resource_name> is an XML resource, it throws an exception.

The reason might be in GetHandler.kt , lines 98-111.

If this is needs to be updated, then a 400 Bad Request can be set if no ACCEPT header was set in GET handler. Otherwise the issue can be ignored.

redwanulsourav avatar Mar 18 '23 11:03 redwanulsourav

Bad request would be ideal, yes

JohannesLichtenberger avatar Mar 18 '23 11:03 JohannesLichtenberger

Just realized that without bad request handler implemented, it is going to throw an exception no matter how it is handled. I will probably delete this issue and work on the refactorings and the bad request handler.

redwanulsourav avatar Mar 18 '23 11:03 redwanulsourav