sirix icon indicating copy to clipboard operation
sirix copied to clipboard

Fix Sonar issues

Open JohannesLichtenberger opened this issue 3 years ago • 4 comments

https://sonarcloud.io/summary/overall?id=sirixdb_sirix

JohannesLichtenberger avatar Oct 25 '21 19:10 JohannesLichtenberger

@JohannesLichtenberger I am working on this, Please assign this to me.

AnishaSrivastava1411 avatar Oct 26 '21 07:10 AnishaSrivastava1411

BTW: I think some of the issues are not real issues, regarding the long / Long autoboxing for instance, but even there I might be wrong.

JohannesLichtenberger avatar Oct 26 '21 07:10 JohannesLichtenberger

Hello @JohannesLichtenberger Can I work on this? I am available to fix a few sonar issues. thanks.

gvdutra avatar Dec 12 '21 07:12 gvdutra

Of course :-)

JohannesLichtenberger avatar Dec 12 '21 09:12 JohannesLichtenberger

Hi @JohannesLichtenberger Raised a PR: https://github.com/sirixdb/sirix/pull/545

slashgk avatar Oct 31 '22 12:10 slashgk

Hi @JohannesLichtenberger Raised a PR: https://github.com/sirixdb/sirix/pull/667

slashgk avatar Oct 04 '23 07:10 slashgk

Hi @JohannesLichtenberger Raised a PR: https://github.com/sirixdb/sirix/pull/669

persy97 avatar Oct 04 '23 17:10 persy97

@persy97 that's not enough for a meaningful contribution, sorry

JohannesLichtenberger avatar Oct 04 '23 17:10 JohannesLichtenberger

@JohannesLichtenberger Pushed some more sonar fixes in the same PR. Please take a look.

persy97 avatar Oct 07 '23 06:10 persy97

Thanks, but I think a cast is missing :)

JohannesLichtenberger avatar Oct 07 '23 11:10 JohannesLichtenberger

Can you trigger the build again?

persy97 avatar Oct 07 '23 11:10 persy97

Hi @JohannesLichtenberger raised a PR: #671 can someone from maintainer approve?

Naman0133 avatar Oct 14 '23 05:10 Naman0133

Hi @JohannesLichtenberger raised a PR: https://github.com/sirixdb/sirix/pull/674 can someone from maintainer approve?

Salonimalhotra avatar Oct 26 '23 10:10 Salonimalhotra

Hi @JohannesLichtenberger raised a PR: https://github.com/sirixdb/sirix/pull/676 can someone from maintainer approve?

smirti-barnwal avatar Oct 27 '23 04:10 smirti-barnwal