MobileFaceNet_TF icon indicating copy to clipboard operation
MobileFaceNet_TF copied to clipboard

Performance issues in your project (by P3)

Open DLPerf opened this issue 4 years ago • 1 comments

Hello! I've found a performance issue in your project: batch() should be called before map(), which could make your program more efficient. Here is the tensorflow document to support it.

Detailed description is listed below:

  • /train_nets.py: dataset.batch(args.train_batch_size)(here) should be called before dataset.map(parse_function)(here).
  • /utils/data_process.py: dataset.batch(32)(here) should be called before dataset.map(parse_function)(here).

Besides, you need to check the function called in map()(e.g., parse_function called in dataset.map(parse_function)) whether to be affected or not to make the changed code work properly. For example, if parse_function needs data with shape (x, y, z) as its input before fix, it would require data with shape (batch_size, x, y, z).

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

DLPerf avatar Aug 30 '21 09:08 DLPerf

Hello, I'm looking forward to your reply~

DLPerf avatar Nov 04 '21 09:11 DLPerf