Payton Swick

Results 85 comments of Payton Swick

This issue is in-progress. See the checklist in the issue description.

All the unix-specific code should now be moved to `ShellOperator`, which means we should be able to try implementing a Windows version now.

Definitely. These are good ideas and can totally be added.

We _could_ create an option to have this sniff scan comments for symbols; it would also help in other places where symbols are used in comments (like phpunit). However, this...

> Just a note: it also gives false "unused" warnings when using an import only within a block of PHPDoc, like this: That's expected. PHPDoc are really just comments. There...

Thanks for bringing this up! I haven't personally used Laravel, but if I can get a list of all their global functions, I can easily add a built-in exception list...

> I'm not sure that ignoreGlobalsWhenInGlobalScope works though. Sorry for the confusion, when I said "if you'd prefer to ignore that warning when you're already in the global namespace, you...

Thanks for the screenshot! Your regular expression is `/^(now|collect\S+)$/` which says, "ignore a symbol named `now` or a symbol that starts with `collect` but is followed by one or more...

So: an additional warning for fully-qualified symbols? Yes, that's certainly do-able. Probably a good idea so that users can have more customization options for this sniff. I'm curious about the...

Ahh, right. That makes sense. Thanks!