Payton Swick

That sounds like a good idea. A lot of the code in this sniff has been implemented in a "make the tests pass and we can clean it up later"...

I agree. Maybe something like "if the variable is an argument of a function that is a method of an abstract class and the method body is empty, then do...

I think this is actually more easily fixable than I thought. Right now (unless I'm missing something) the only reason we track pass-by-reference functions is in order to determine if...

🤔 Ah, I think I found it. It's black, but it's "bright" black. In my terminals, bright black is a lighter color, and I think that's the default (MacOS iTerm...

Works for me! +1 for this.

> I'm not sure it's needed in Calypso, but it should be on the email receipt. If there's nowhere else tracking that, let's track that here? Since this is an...

I'm going to grab this as it's related to https://github.com/Automattic/wp-calypso/pull/83768

https://github.com/Automattic/wp-calypso/pull/83768 will handle most of this for introductory offers, but will not cover other types of promotional pricing. For that we'll need something like what checkout has for its TOS.

Moving this to the backlog as a later enhancement.

This PR broke some tests (well, it made them flaky) by moving the query client into the global scope. https://github.com/Automattic/wp-calypso/pull/88006 should fix it. Granted, the tests were originally creating the...