Payton Swick

I made a separate issue for this bug here: https://github.com/sirbrillig/phpcs-variable-analysis/issues/215 since I believe it also affects 3.0.

@Levivb Could you try https://github.com/sirbrillig/phpcs-variable-analysis/releases/tag/v2.10.0-beta.3 to see if there's any other issues you can see?

No worries! My own testing hasn't shown anything problematic. I mostly want to be sure that the false positives you saw are gone. I'm sure there's more bugs (there always...

Thanks! That's really helpful to know. I previously had [a major performance issue](https://github.com/sirbrillig/phpcs-variable-analysis/pull/200) which I was able to track down and fix thanks to a copy of a file that...

Thanks! (I adjusted your comment to make the code a block.) Super helpful. It turns out that there's [some pretty slow recursion](https://github.com/sirbrillig/phpcs-variable-analysis/blob/50486555fae72a6401ad0337d0b71fd9e775b2f2/VariableAnalysis/Lib/Helpers.php#L607-L609) going on in `getListAssignments` for nested list destructuring....

> Great work on pinpointing the responsible code that fast 😁 xdebug profiling is magical.

> already managed to bring it down from 120 seconds to 15, but still feel it can probably be brought down further. Thanks for the info! I'm excited for when...

> +1 to tag a new 2.x release 2.11.4 or 2.12.0, please it will help to speed-up adoption 🤔 To my knowledge, nothing has changed since 2.11.3 was tagged except...

Ah, good point. I've released 2.11.4 which now includes that commit. https://github.com/sirbrillig/phpcs-variable-analysis/releases/tag/v2.11.4

It looks like it originated in 2011 here: 385b5a8af5e470e7bb7e4f1f8d676213896fdee6 Sounds like a great idea to replace that.