homer7-docker icon indicating copy to clipboard operation
homer7-docker copied to clipboard

Fix corrupt json

Open Alan01252 opened this issue 6 years ago • 6 comments

Tested on kibana locally this import succeeds and all the visualisations appear to work as expected.

It's difficult to know if these are the latest versions of the visualisations as the authors intended due to the complexity of the nested json. As such this is more of a "best guess" of what the json should be.

fixes #6

Alan01252 avatar Dec 28 '18 21:12 Alan01252

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Dec 28 '18 21:12 CLAassistant

I think there's definitely some JSON missing, for instance, the "Test FLOW" visualisation, as shown in the image on the README for this example, is missing completely in original and in this pull request.

Alan01252 avatar Dec 28 '18 22:12 Alan01252

Thanks @Alan01252 are you referring to the Vega flows or the IP Flow Diagrams? IP Flow Diagram requires an additional Kibana plugin and can't be done with Vega juet yet. image

lmangani avatar Dec 28 '18 22:12 lmangani

Thanks @Alan01252 are you referring to the Vega flows or the IP Flow Diagrams? IP Flow Diagram requires an additional Kibana plugin and can't be done with Vega juet yet. image

Yep, that's the one I was referring to! Sorry, my misunderstanding!

Alan01252 avatar Dec 28 '18 22:12 Alan01252

@Alan01252 here's what was used for the demo, unfortunately no time to maintain it: https://github.com/lmangani/kibana_diagram

lmangani avatar Dec 29 '18 00:12 lmangani

@Imangani that's perfect thanks you very much!

Alan01252 avatar Dec 29 '18 10:12 Alan01252