heplify icon indicating copy to clipboard operation
heplify copied to clipboard

Adds Discard uninteresting SIP packets by Destination IP(s) flag

Open nzspearo opened this issue 3 years ago • 6 comments
trafficstars

Adds a new flag to support discarding SIP packets by destination IP(s)

Same logic as already implemented src IP, just adds it for dst IP(s) also

nzspearo avatar Jun 03 '22 04:06 nzspearo

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: kYroL01
:x: Matt Cornish


Matt Cornish seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 03 '22 04:06 CLAassistant

Hi @nzspearo Could you please refresh your PR in order to be in sync with master ? Thanks

kYroL01 avatar Aug 12 '22 16:08 kYroL01

Hi @nzspearo Could you please refresh your PR in order to be in sync with master ? Thanks

I think this is done now. I've got that CLA issue, I've singed it but it does not seem to be linked to my commits, not sure why.

nzspearo avatar Aug 13 '22 09:08 nzspearo

Hi @nzspearo Could you please refresh your PR in order to be in sync with master ? Thanks

I think this is done now. I've got that CLA issue, I've singed it but it does not seem to be linked to my commits, not sure why.

Thanks & sorry about this issue. You're probably using a different git identity or email when signing up the CLA?

lmangani avatar Aug 13 '22 09:08 lmangani

CI still failing as follows:

Error: sniffer/sniffer.go:278:12: cfgMain.HepCollector undefined (type *config.Config has no field or method HepCollector) Error: sniffer/sniffer.go:279:37: cfgMain.HepCollector undefined (type *config.Config has no field or method HepCollector) Error: sniffer/sniffer.go:281:35: cfgMain.CollectOnlySip undefined (type *config.Config has no field or method CollectOnlySip) Error: Process completed with exit code 2.

lmangani avatar Aug 13 '22 09:08 lmangani

@nzspearo your PR was failing because not sync with latest commit in master. I fixed it. Please try again to sign Contributor License Agreement and we're happy to merge it

kYroL01 avatar Sep 04 '22 09:09 kYroL01

Already implemented here https://github.com/sipcapture/heplify/pull/221 Thanks anyway

kYroL01 avatar Oct 03 '22 07:10 kYroL01