minisketch icon indicating copy to clipboard operation
minisketch copied to clipboard

header: Delete default Minisketch constructor

Open sedited opened this issue 1 year ago • 1 comments

I might be missing a reason for having the default constructor, but it is not used anywhere and trying to use one of its methods will cause a segfault.

sedited avatar Jun 12 '24 15:06 sedited

Concept ACK. @TheCharlatan and I discussed this and couldn't find a user of the default ctor.

Barely any functions check for a valid m_minisketch before using it. So rather than adding the checks, we figured it made sense to just eliminate the possibility.

As far as I can see, without this ctor, the only way to hit a null m_minisketch would be a moved-from object, which is usually assumed to be undefined unless otherwise specified.

theuni avatar Jun 12 '24 16:06 theuni

ACK 5cc7d208664382b5327987b7b60549746344ca7e

sipa avatar May 13 '25 17:05 sipa