Pieter Wuille

Results 55 issues of Pieter Wuille

Unsure if this should be in upstream, but it may be useful for things like shaving off a few bytes from signatures.

feature

Alternative to #902 (but contains part of it). Permit a configure-time option to use a trick to let the compiler prove our `VERIFY_CHECK` statements are side-effect free. See details on...

Suggested here: https://github.com/bitcoin-core/secp256k1/pull/793#issuecomment-671322287 This should include explicitly selected configuration options (the ones passed through through `libsecp256k1-config.h`), but also C-detected configuration like added in #787 (endianness) and #793 (__int128).

Suggested [here](https://github.com/bitcoin-core/secp256k1/pull/772#issuecomment-667884910) by Andy Polyakov. This is shorter, easier to reason about, more likely to not contain branches, and likely (slightly) faster too.

Fix a bug in the script_size sanity-check in the miniscript string parser, found by oss-fuzz in https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=51636, and introduced in e8cc2e4afc1142aa2b3da19cd5c17deea9963244 (#25540). This bug would cause an assertion failure when...

Builds on top of #24343. Adds additional tests, and makes `ToPrivateString()` always succeed, using pubkeys in case privkeys are unavailable.

Wallet
Needs rebase
Descriptors

The fuzzer goes through a sequence of operations that get applied to both a real stack of `CCoinsViewCache` objects, and to simulation data, comparing the two at the end.

It seems modern compilers don't realize that all invocations of operator""_mst can be evaluated at compile time, despite the `constexpr` keyword. Since C++20, we can force them to evaluate at...

Descriptors
CI failed

Closes #28941. Our current tests for serfloat verify two distinct properties: 1. Whether they roundtrip `double`->`uint64_t`->`double` (excluding NaN values) on all systems. 2. Whether on systems with a typical floating...

CI failed
Needs backport (26.x)