Yonghwan SO comments

Results 105 comments of


                                            Yonghwan SO

change_column doesn't support {"default": null}

`DROP DEFAULT` is not currently supported.

Add support for genji - A pure golang sql db

Not sure if the core buffalo team has enough bandwidth to work on it, but PRs are always welcome!

migration_table_name is Appended to Postgres Connection String

At the first place, having that `option` in that place is somewhat odd to me. will check it later.

A problem with the Pop Model

If the issue is about table creation as you mentioned, the mentioned issue #447 (which was https://github.com/gobuffalo/buffalo/issues/1800) is fixed so I am closing this issue.

fix eager creation for associations by adding where clause

Hello @xixinjie, Thank you for reporting this issue and contribution. I took a look at the issue and definitely the original usage was problematic. Please resolve the review comment, then...

mysqldump failing in tests

Yeah, adding an option to the hard-coded command must be careful and need to check the oldest supported version. I rolled back the change in the code base and it...

mysqldump failing in tests

One more point: when it runs in a production, dumping schema could be optional. Will check that in the next cycle.

removed simple+incorrect IN expansion

Hello @truesilver92, thanks for your contribution! The description of the PR looks nice but the patch is somewhat odd to me. I will take care of the code tomorrow and...

removed simple+incorrect IN expansion

Although the direction of supporting slice as an argument for `IN` could be nice (as introduced by [4] for the first time), this PR cannot be merged for several reasons:...

Customize generated PostgreSQL created_at and updated_at columns to use timestamptz

I agree. the current behavior could be an issue for global applications, and it is not a best practice even though the behavior was common in the past days. Actually,...